Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pipeline function for code usage | Updates on torch version #64

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

spirosmaggioros
Copy link
Member

@spirosmaggioros spirosmaggioros commented Jan 10, 2025

I updated the torch version for up to 2.3.1 for now. The pipeline is tested and the torch version of the other packages(DLMUSE, DLICV, DLWMLS and Spare) will be updated as well once tested.

Also, implemented @AlexanderGetka-cbica 's request for a pipeline function (run_dlicv_pipeline) so it can be used instead of calling the CLI command inside third-party code.

Also, good thing that the installation of torch with cuda works well. Just fyi the pipeline works with torch 2.4.* versions as well(tested this because cuda 12.4 doesn't support 2.3.1)

P.S: Thanks for the VM Alex.

@spirosmaggioros spirosmaggioros added the enhancement New feature or request label Jan 10, 2025
@spirosmaggioros spirosmaggioros self-assigned this Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (99e4a7e) to head (5d746bb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   71.03%   72.42%   +1.39%     
==========================================
  Files           3        3              
  Lines         290      301      +11     
==========================================
+ Hits          206      218      +12     
+ Misses         84       83       -1     
Files with missing lines Coverage Δ
NiChart_DLMUSE/__init__.py 100.00% <100.00%> (ø)
NiChart_DLMUSE/utils.py 57.36% <100.00%> (+0.52%) ⬆️
tests/test_utils.py 98.18% <100.00%> (+0.20%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant